<html>
<head><meta charset="utf-8"><title>Felix wrestles with Github · t-compiler/wg-nll · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/index.html">t-compiler/wg-nll</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html">Felix wrestles with Github</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="135391900"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135391900" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135391900">(Oct 08 2018 at 09:55)</a>:</h4>
<p>its not a big deal; I wrote the comment on a couple PR's but then the comment would get outdated by an update to a the PR</p>



<a name="135391910"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135391910" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135391910">(Oct 08 2018 at 09:55)</a>:</h4>
<p>and so it would get hidden</p>



<a name="135391915"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135391915" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135391915">(Oct 08 2018 at 09:55)</a>:</h4>
<p>I'll go find the cases where I can remember it</p>



<a name="135391974"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135391974" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135391974">(Oct 08 2018 at 09:56)</a>:</h4>
<p>Ah, I always try to make sure I respond to every comment, I’ll try double check that more in future.</p>



<a name="135391984"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135391984" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135391984">(Oct 08 2018 at 09:57)</a>:</h4>
<p><code>Pending</code> ?</p>



<a name="135391988"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135391988" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135391988">(Oct 08 2018 at 09:57)</a>:</h4>
<p>hmm</p>



<a name="135391999"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135391999" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135391999">(Oct 08 2018 at 09:57)</a>:</h4>
<p>This was the second one I wrote; I'm still looking for the first: <a href="https://github.com/rust-lang/rust/pull/54831/files#diff-f5a7553f1d02fe100fab92a0f135d0fdR230" target="_blank" title="https://github.com/rust-lang/rust/pull/54831/files#diff-f5a7553f1d02fe100fab92a0f135d0fdR230">https://github.com/rust-lang/rust/pull/54831/files#diff-f5a7553f1d02fe100fab92a0f135d0fdR230</a></p>



<a name="135392013"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135392013" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135392013">(Oct 08 2018 at 09:57)</a>:</h4>
<p>There’s no comment there.</p>



<a name="135392051"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135392051" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135392051">(Oct 08 2018 at 09:58)</a>:</h4>
<p>If it’s pending you didn’t submit the review.</p>



<a name="135392124"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135392124" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135392124">(Oct 08 2018 at 09:59)</a>:</h4>
<p>wait so comments I write don't show up??</p>



<a name="135392125"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135392125" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135392125">(Oct 08 2018 at 09:59)</a>:</h4>
<p>argh!</p>



<a name="135392126"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135392126" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135392126">(Oct 08 2018 at 09:59)</a>:</h4>
<p>/me angry</p>



<a name="135392217"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135392217" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135392217">(Oct 08 2018 at 10:00)</a>:</h4>
<p>That's really frustrating</p>



<a name="135392243"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135392243" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135392243">(Oct 08 2018 at 10:01)</a>:</h4>
<p>maybe it makes sense in terms of overall work flow, but the fact that this note is not actually registered for anyone else to see, and that the feedback to <em>me</em> about that is just this <code>Pending</code> label (which I'm not certain even shows up in the mobile phone interface ...)</p>



<a name="135392283"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135392283" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135392283">(Oct 08 2018 at 10:02)</a>:</h4>
<p>I'm now wondering how many comments I've made have been silently discarded due to this...</p>



<a name="135392298"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135392298" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135392298">(Oct 08 2018 at 10:03)</a>:</h4>
<p>anyway, sorry, my own github fails are obviously not your problem.</p>



<a name="135392304"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135392304" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135392304">(Oct 08 2018 at 10:03)</a>:</h4>
<p>If you put a comment in I'd always respond and try resolve it.</p>



<a name="135392346"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135392346" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135392346">(Oct 08 2018 at 10:04)</a>:</h4>
<p>right, but I just didn't know that my comments were being held by github as part of its review system</p>



<a name="135392354"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135392354" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135392354">(Oct 08 2018 at 10:04)</a>:</h4>
<p>I understood that it presented me with this embedded choice-box of "approve, reject, etc"</p>



<a name="135392363"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135392363" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135392363">(Oct 08 2018 at 10:05)</a>:</h4>
<p>but I <em>assumed</em> that if I didn't make any choice, that my comment would still show up in the meantime and be visible</p>



<a name="135392379"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135392379" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135392379">(Oct 08 2018 at 10:05)</a>:</h4>
<p>Normally the "no choice" option is neither approve or reject but just "comment" in that little box.</p>



<a name="135392431"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135392431" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135392431">(Oct 08 2018 at 10:06)</a>:</h4>
<p>I now understand that I need to either hit submit (with "no choice") immediately. (That, or I need to finish reading the PR and then make a choice, of course).</p>



<a name="135392444"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135392444" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135392444">(Oct 08 2018 at 10:06)</a>:</h4>
<p>but I just didn't know that the way I was using it was broken. Because I don't, you know, visit github issues without being logged in as me</p>



<a name="135392448"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135392448" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135392448">(Oct 08 2018 at 10:06)</a>:</h4>
<p>Yeah, it's easy to miss.</p>



<a name="135392451"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135392451" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135392451">(Oct 08 2018 at 10:06)</a>:</h4>
<p>anyway I've now identified both the cases where I made the comments and have now submitted them.</p>



<a name="135392458"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135392458" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135392458">(Oct 08 2018 at 10:07)</a>:</h4>
<p>Great, I'll get those just now.</p>



<a name="135428493"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135428493" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135428493">(Oct 08 2018 at 21:17)</a>:</h4>
<p>w/r/t <a href="https://github.com/rust-lang/rust/pull/54802#discussion_r223396345" target="_blank" title="https://github.com/rust-lang/rust/pull/54802#discussion_r223396345">your comment from earlier</a> - I think it depends when making the review whether you press "add a comment" or "start a review". One of them will add a pending comment to be later be submitted with others all at once; the other will just add it straight away.</p>



<a name="135428539"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135428539" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135428539">(Oct 08 2018 at 21:18)</a>:</h4>
<p>it would be nice if there were <em>some</em> indication on the PR of a "review in progress"</p>



<a name="135428575"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135428575" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135428575">(Oct 08 2018 at 21:19)</a>:</h4>
<p>Somewhat related, one thing that GitLab does which is nice is in the issue listing, it has a little icon if there's a PR up for that issue. Would be nice for something similar on GitHub, but also a similar icon on PRs for in-progress reviews.</p>



<a name="135452570"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135452570" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135452570">(Oct 09 2018 at 08:31)</a>:</h4>
<p><span class="user-mention" data-user-id="116107">@davidtwco</span> the <a href="https://github.com/sindresorhus/refined-github" target="_blank" title="https://github.com/sindresorhus/refined-github">refined github extension</a> offers this. Here's an example from one of yours: next to "Open" is the PR number which will close this issue <a href="/user_uploads/4715/52I4OMM8o-cGEMa9WRv5k9xi/pasted_image.png" target="_blank" title="pasted_image.png">#53040</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/52I4OMM8o-cGEMa9WRv5k9xi/pasted_image.png" target="_blank" title="#53040"><img src="/user_uploads/4715/52I4OMM8o-cGEMa9WRv5k9xi/pasted_image.png"></a></div>



<a name="135453293"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/Felix%20wrestles%20with%20Github/near/135453293" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/Felix.20wrestles.20with.20Github.html#135453293">(Oct 09 2018 at 08:48)</a>:</h4>
<p>Last time I tried that it made some things look strange so I uninstalled it, might be worth another go. I always wanted <a href="https://github.com/hzoo/contributors-on-github" target="_blank" title="https://github.com/hzoo/contributors-on-github">this extension</a> to be available for Firefox.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>